Skip to content

feat(integriq): build open-formulieren-submits-into-its-case - #3675

Merged
rubenvdlinde merged 3 commits into
developmentfrom
quality/build-open-formulieren-submits-into-its-case
Nov 17, 2026
Merged

rubenvdlinde merged 3 commits into
developmentfrom
quality/build-open-formulieren-submits-into-its-case

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Builds openspec/changes/open-formulieren-submits-into-its-case (integriq's half of the form-submits-into-its-destination change): an Open Formulieren submit creates its case in the inbound request, and a form mapping is checked against its case schema before it may be active.

Tasks done

  • 1.1 Saving an openformulieren_form_mapping with isEnabled true runs OpenRegister's FormDestinationValidatorInterface against the destination schema (MappingCheck, OpenFormulierenMappingGuardListener on OpenRegister's creating/updating events). Findings refuse the save with 422 and the findings (required-unmapped on caseType, ...). A disabled mapping saves unchecked, so it can be kept as a draft. The mapping schema gains destinationRegister (default dossiq), destinationSchema (default case), fixedValues (for example the case type) and propertyMap (contract field to destination property; by default title→title, summary→description, channel→intakeChannel; priority is derived by a dossiq case and not written).
  • 1.2 OpenFormulierenController::inbound maps the payload and calls OpenRegister's FormSubmitServiceInterface::submit in the same request (DestinationSubmitter), as the connection's account, with the submission id as idempotency key and externalReference. It answers 201 with OpenRegister's answer (reference, id, ...), the refusal's status with its findings (422), or 503 when the destination cannot be written now. No openformulieren_submission is written.
  • 1.3 Every submit leaves one audit-log line (CriticalActionPerformedEvent) with the body's sha256, the time and the outcome; nothing is kept to process later.
  • 1.4 (part) occ integriq:openformulieren:drain: a dry run lists the received and failed submissions; --apply submits each through the new path as the connection account and marks it handed_off with its case. Idempotent: the submission id is the key, so running it twice creates no second case.

Tasks left, and why

  • 1.4 (rest): removing the staging schema and the handoff() path waits for a drain that reports zero pending on the live instances (the proposal's rollback rule).
  • 1.5 DSO: the DSO activity mapping is an activity → case-type table, not a field mapping the validator judges; which mapping the check runs on needs a decision first.
  • 2.1 composer check:strict / openspec validate: phpcs and phpstan ran clean on every touched lib file; the full strict run is left to CI.
  • Attachments: the inbound path does not carry Open Formulieren attachments onto the case yet (the old staging path fetched them onto the submission). Follow-up.

Tests

New: FormDestinationWriteTest, MappingCheckTest, DestinationSubmitterTest, SubmissionDrainTest, OpenFormulierenMappingGuardListenerTest (201, 422, idempotent repeat, the no-staging control, the mapping refusal). Updated the three Open Formulieren controller tests for the new inbound answer, the registration-order and service-registrar goldens for the new alias and listener, and the rule-processors golden for the stub's new trailing argument. Test stubs for OpenRegister's form classes and main's save options are copies of main's method shapes; the ObjectService stub and its four test subclasses accept main's ObjectSaveOptions.

Suite

Unit suite before (development): 4 failing tests (JobsControllerTest::testUnknownJobIsNotFound, two CallServiceTest list-method tests, SynchronizationSynchronizeEntryGoldenTest). After: the same 4, nothing new; 9552 tests.


Generated by Claude Code

An Open Formulieren submit creates its case in the inbound request through OpenRegister's form submit path (submission id as idempotency key and externalReference; 201 or the refusal's status), with one audit-log line of body hash, time and outcome and no staged submission. A form mapping is checked against its destination schema by OpenRegister's form destination validator before it may be active.

Assisted-by: ClaudeCode:claude-opus-5-5
occ integriq:openformulieren:drain: lists the received and failed staged submissions, and with --apply submits each through the inbound path as the connection account (submission id as idempotency key) and marks it handed_off with its case. The ObjectService test stub and its subclasses accept main's ObjectSaveOptions.

Assisted-by: ClaudeCode:claude-opus-5-5
…s-case [skip ci]

Takes development's openregister main stubs (ObjectSaveOptions and
friends, saveObject(object, options, rbac, multitenancy)) over the
branch's interim options parameter; the drain test double and the
rule-processor golden follow that signature.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 5a67c82 into development Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant